feat(traffic_light): depend on is_simulation for scenario simulator (… #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utowarefoundation#6498) * feat(traffic_light): depend on is_simulation for scenario simulator Signed-off-by: Takayuki Murooka <[email protected]> * fix comments Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
requested review from
satoshi-ota,
shmpwk,
tkimura4,
rej55,
isamu-takagi,
soblin,
kosuke55,
kyoichi-sugahara,
mkuri,
maxime-clem,
taikitanaka3,
takayuki5168,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
TomohitoAndo
removed request for
rej55,
takayuki5168,
TakaHoribe,
soblin,
kyoichi-sugahara,
kosuke55,
shmpwk,
isamu-takagi,
satoshi-ota,
tkimura4,
taikitanaka3,
maxime-clem and
zulfaqar-azmi-t4
This was referenced Mar 6, 2024
TomohitoAndo
added a commit
that referenced
this pull request
Apr 11, 2024
#1171) feat(traffic_light): depend on is_simulation for scenario simulator (autowarefoundation#6498) * feat(traffic_light): depend on is_simulation for scenario simulator * fix comments * fix --------- Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick this PR.
This PR extends the feature to deal with the traffic signal depending on whether it's a simulation or not, implemented in the following PR.
autowarefoundation#6468
Related
launcher PR
JIRA
Tests performed
PSim
simplescreenrecorder-2024-03-05_14.15.27.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.